This repository was archived by the owner on Feb 18, 2024. It is now read-only.
Test create-project buildable in development mode #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
approved these changes
Sep 6, 2018
| assert.file(join(dir, '.neutrinorc.js')); | ||
| assert.file(join(dir, 'webpack.config.js')); | ||
| assert.file(join(dir, '.eslintrc.js')); | ||
|
|
||
| await lintable(t, dir); | ||
| await buildable(t, dir); | ||
|
|
||
| const pkg = require(pkgPath); // eslint-disable-line import/no-dynamic-require | ||
|
|
||
| if ('start' in pkg.scripts) { |
There was a problem hiding this comment.
As far as I can tell, the @neutrinojs/library preset is the only one that create-project does not configure a start script for.
However the library preset does have prod-only code:
neutrino/packages/library/index.js
Lines 101 to 103 in 1b4f92b
...so perhaps should still be tested in development mode?
Also, is it worth adding a comment saying something about "building in development mode to emulate start, until we can come up with something better"?
There was a problem hiding this comment.
Definitely. I'll add the comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #886.
This patch is a stop-gap for testing create-project output works in development mode by only overriding the build command, not start.