Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Refresh lockfile & bump in-range dependency versions #1138

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Refresh lockfile & bump in-range dependency versions #1138

merged 1 commit into from
Sep 24, 2018

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Sep 24, 2018

Bumping the version ranges themselves in theory shouldn't be necessary, however it reduces the chance of package-managers consolidating deps with an older version & making it harder when we try to debug any issues user encounter.

I've also bumped the peerDependencies (hence being a breaking change), which should help remind users to upgrade if they are still using older versions of them.

The lockfile has also been refreshed, which fixes #1137.

@edmorley edmorley added this to the v9 milestone Sep 24, 2018
@edmorley edmorley self-assigned this Sep 24, 2018
@eliperelman
Copy link
Member

Upgrading peerDependencies could essentially force users between choosing between neutrino and a certain version of webpack, and I would prefer not to make that choice. They may be reminded to upgrade their webpack version, but if they can't then it may just be annoying for us to enforce that. I like to use peerDependencies to mark the minimum or breaking version of a package that works with neutrino.

@edmorley
Copy link
Member Author

Yeah I agree; one of the reason I decided to include it was because of this on IRC - but perhaps I misunderstood?

15:52 <•emorley> and I was thinking before final I could bump all the in-range deps to force latest versions
15:52 <•Eli> ++++++++
15:52 <•emorley> but none of those are urgent
16:02 <•Eli> emorley: also peerDeps

@eliperelman
Copy link
Member

eliperelman commented Sep 24, 2018

Yeah sorry, I meant changing all the peerDeps from "neutrino": "^9.0.0-0" to "neutrino": "^9.0.0".

@edmorley
Copy link
Member Author

Ah I thought lerna did that for us - but I guess not given lerna/lerna#1575?
I'll update the PR.

Bumping the version ranges themselves in theory shouldn't be necessary,
however it reduces the chance of package-managers consolidating deps
with an older version & making it harder when we try to debug any
issues user encounter.

The lockfile has also been refreshed, which fixes #1137.
@edmorley
Copy link
Member Author

Updated

Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@edmorley edmorley merged commit 52e78ec into neutrinojs:master Sep 24, 2018
@edmorley edmorley deleted the bump-in-range-deps branch September 24, 2018 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants