Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Clean up the display of errors during middleware instantiation #1163

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Clean up the display of errors during middleware instantiation #1163

merged 1 commit into from
Oct 11, 2018

Conversation

edmorley
Copy link
Member

Before:

$ webpack --mode production
/app/node_modules/webpack-cli/bin/cli.js:244
                                throw err;
                                ^

Error: Using "env" in middleware has been removed. Apply middleware conditionally instead.
    at Neutrino.use (/app/node_modules/neutrino/Neutrino.js:220:15)
    at module.exports (/app/node_modules/neutrino/index.js:35:14)
    at module.exports (/app/webpack.config.js:9:10)
    ...

After:

$ webpack --mode production

An error occurred when loading the Neutrino configuration.

Error: Using "env" in middleware has been removed. Apply middleware conditionally instead.
    at Neutrino.use (/app/node_modules/neutrino/Neutrino.js:220:15)
    at module.exports (/app/node_modules/neutrino/index.js:36:16)
    at module.exports (/app/webpack.config.js:9:10)
    ...

Before:

```
$ webpack --mode production
/app/node_modules/webpack-cli/bin/cli.js:244
                                throw err;
                                ^

Error: Using "env" in middleware has been removed. Apply middleware conditionally instead.
    at Neutrino.use (/app/node_modules/neutrino/Neutrino.js:220:15)
    at module.exports (/app/node_modules/neutrino/index.js:35:14)
    at module.exports (/app/webpack.config.js:9:10)
    ...
```

After:

```
$ webpack --mode production

An error occurred when loading the Neutrino configuration.

Error: Using "env" in middleware has been removed. Apply middleware conditionally instead.
    at Neutrino.use (/app/node_modules/neutrino/Neutrino.js:220:15)
    at module.exports (/app/node_modules/neutrino/index.js:36:16)
    at module.exports (/app/webpack.config.js:9:10)
    ...
```
@edmorley edmorley added the bug label Oct 10, 2018
@edmorley edmorley added this to the v9 milestone Oct 10, 2018
@edmorley edmorley self-assigned this Oct 10, 2018
Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@edmorley edmorley merged commit b376e5d into neutrinojs:master Oct 11, 2018
@edmorley edmorley deleted the improve-error-display branch October 11, 2018 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants