This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
jest: Use babel-jest instead of a custom implementation #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously just reimplementing parts of it, and not using the latest recommended Babel settings (such as still setting `retainLines: true` when sourcemaps are supported natively). There isn't currently a way to set the babel-jest `createTransformer()` options via Jest configuration/globals, so we instead have to resort to using an environment variable. This has the limitation of only supporting Babel options that are serializable (virtually all commonly used configuration options are), with any others being silently omitted. However this was already the case when using `globals` anyway. See: https://github.com/facebook/jest/blob/v23.6.0/packages/babel-jest/README.md https://github.com/facebook/jest/blob/v23.6.0/packages/babel-jest/src/index.js Fixes #851.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously just reimplementing parts of it, and not using the latest recommended Babel settings (such as still setting
retainLines: truewhen sourcemaps are supported natively).There isn't currently a way to set the babel-jest
createTransformer()options via Jest configuration/globals, so we instead have to resort to using an environment variable. This has the limitation of only supporting Babel options that are serializable (virtually all commonly used configuration options are), with any others being silently omitted. However this was already the case when usingglobalsanyway.See:
https://github.com/facebook/jest/blob/v23.6.0/packages/babel-jest/README.md
https://github.com/facebook/jest/blob/v23.6.0/packages/babel-jest/src/index.js
Fixes #851.