Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

dev-server: Enable in-page overlay for display of errors #1217

Merged
merged 1 commit into from
Nov 20, 2018
Merged

dev-server: Enable in-page overlay for display of errors #1217

merged 1 commit into from
Nov 20, 2018

Conversation

edmorley
Copy link
Member

See:
https://webpack.js.org/configuration/dev-server/#devserver-overlay

Note this change 'relies' on #1216, in that without that change all linter errors would be displayed in the overlay too, which is likely too noisy (given that many rules are for stylistic issues that should not block viewing the dev-server page output).

Fixes #1131.

See:
https://webpack.js.org/configuration/dev-server/#devserver-overlay

Note this change 'relies' on #1216, in that without that change all
linter errors would be displayed in the overlay too, which is likely
too noisy (given that many rules are for stylistic issues that should
not block viewing the dev-server page output).

Fixes #1131.
@edmorley edmorley added this to the v9 milestone Nov 19, 2018
@edmorley edmorley self-assigned this Nov 19, 2018
@edmorley
Copy link
Member Author

edmorley commented Nov 19, 2018

"breaking" change in the sense that it causes people's workflow to potentially change slightly.

Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@edmorley edmorley merged commit b2b5af9 into neutrinojs:master Nov 20, 2018
@edmorley edmorley deleted the devserver-overlay branch November 20, 2018 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants