Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Rename getWebpackOptions to getWebpackConfig. #123

Merged
merged 1 commit into from
Mar 19, 2017
Merged

Rename getWebpackOptions to getWebpackConfig. #123

merged 1 commit into from
Mar 19, 2017

Conversation

jaridmargolin
Copy link
Contributor

No description provided.

@jaridmargolin
Copy link
Contributor Author

One other option here could be to actually just use a getter and access via api.webpackConfig. Thoughts?

@jaridmargolin
Copy link
Contributor Author

Although, getWebpackConfig() may better describe that work is done to get the value.

@eliperelman
Copy link
Member

Agreed, I like having the method call over the prop.

@eliperelman eliperelman merged commit 2b0754a into neutrinojs:master Mar 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eliperelman eliperelman eliperelman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaridmargolin @eliperelman