Neutrino webpack

[jaridmargolin]

This is the least tested functionality in the neutrino package. Hard to make changes with a high degree of confidence. I am willing to write tests around this, but wanted to discuss what it would look like first. Any thoughts? I don't see a path to mocking the tests. May actually have to compile?

[eliperelman]

Loving this so far!

[eliperelman]

We probably don't need a special noop here, we can either use identity from Ramda, or Function.prototype:

runCommand(command, args = {}, fn = identity) {

runCommand(command, args = {}, fn = Function.prototype) {

[eliperelman]

Maybe this could be consolidated to some defaults:

const config = merge({
  devServer: {
    https: false,
    host: 'localhost',
    port: 5000,
    noInfo: true
  }
}, _config);
const protocol = config.devServer.https ? 'https' : 'http';
const { host, port } = config.devServer;
const url = `${protocol}://${host}:${port}`;

[eliperelman]

Seeing this makes me wish we had ES modules here. sigh

Maybe we can save some nesting by just naming them:

module.exports.handle = /* ... */

module.exports.logStats = /* ... */

module.exports.logErrors = /* ... */

We could also use object shorthand to reduce nesting:

function handle() {}

function logStats() {}

function logErrors() {}

module.exports = {
  handle,
  logStats,
  logErrors
};

[eliperelman]

Testing the stuff that touches Webpack is hard, mostly because we want to avoid actually building something, and if we do, how would we ensure the output is correct, or that is starts as expected? Half that battle is just making sure Webpack operates as expected, and I'm not sure that is a road we even want to go down.

[jaridmargolin]

I don't think the output is necessary to test. It would be great however, if we could test if the command runs without errors. I think this WOULD require actually building assets. Could be similar to the setup in requireMIddleware tests?