This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
clean: Document removal of external directories #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
previously requested changes
Jan 7, 2019
There was a problem hiding this comment.
This patch suffers from the same problem as the original of #723, which is that the allowExternal option here is set at the top of the export object. This option belongs to the middleware, not the Neutrino options.
edmorley
reviewed
Jan 9, 2019
packages/react/README.md
Outdated
| @@ -303,6 +303,22 @@ module.exports = { | |||
| }; | |||
| ``` | |||
|
|
|||
| #### Clean external directories | |||
There was a problem hiding this comment.
I think we should only add a section to the @neutrinojs/clean docs rather than the top-level presets too.
There was a problem hiding this comment.
Thanks for the input. I have updated it.
edmorley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #362