This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
style-loader: use oneof #1281
Merged
style-loader: use oneof #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2019 12:30
|
WIll fix tests momentarily |
|
Tests are passing now! |
|
@eliperelman if you have a chance for another review, take a look. I made some tweaks. |
edmorley
suggested changes
Jan 14, 2019
added 3 commits
January 14, 2019 16:22
edmorley
suggested changes
Jan 16, 2019
There was a problem hiding this comment.
Thank you for working on this - these should be the last few changes I think :-)
Could you also add an entry to the migration guide? It can probably be quite vague and just mention switching to use oneOf and some of the configuration options may have changed etc.
edmorley
reviewed
Jan 17, 2019
Forgot! Now added 🎉 |
timkelty
added a commit
that referenced
this pull request
Jan 18, 2019
Applies Vue style rules as oneOfs, following #1281. * Used https://github.com/vuejs/vue-cli/blob/dev/packages/%40vue/cli-service/lib/config/css.js#L72-L168 as a model * Fixes #1243
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1243 (comment)
Following this merge, we can rebase #1276 and merge that in.