This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Further tweaks to the release process #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
eliperelman
approved these changes
Apr 16, 2019
* Call `yarn changelog` from `release:prepare` rather than during the `version` lifecycle, since `lerna.json` isn't always written by that point. * Add missing "v" prefix to the changelog version number, and switch to using auto-changelog 1.13.0's new `--package <file>` support, so the changelog command doesn't need to use bash command substitution and so is compatible with Windows. * Add `--no-track` to the Git checkout command, so that the new branch doesn't automatically track master (which means pushes end up on the wrong branch). * Mention how to adjust the sed command for it to work on OS X.
|
I've updated the PR to take advantage of the new |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn changelogfromrelease:preparerather than during theversionlifecycle, sincelerna.jsonisn't always written by that point.--package <file>support, so the changelog command doesn't need to use bash command substitution and so is compatible with Windows.--no-trackto the Git checkout command, so that the new branch doesn't automatically track master (which means pushes end up on the wrong branch).