Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Adding documention about web publicPath #141

Merged
merged 1 commit into from
Mar 25, 2017
Merged

Adding documention about web publicPath #141

merged 1 commit into from
Mar 25, 2017

Conversation

eliperelman
Copy link
Member

Fixes #133.

@eliperelman eliperelman merged commit fb95c42 into neutrinojs:master Mar 25, 2017
@tj
Copy link

tj commented Aug 7, 2017

hmm is there an example of what this looks like? I just get:

TypeError: Path must be a string. Received { path: 'build', publicPath: '/' }

For:

module.exports = {
  options: {
    output: {
      path: 'build',
      publicPath: '/'
    }
  }
}

Tried just doing neutrino.options.output.publicPath = as well but seems to be a getter returning nothing, webpack is so confusing :D . For context I'm adding an example for Up which uses API Gateway, so they add /dev /prod to the path.

@eliperelman
Copy link
Member Author

eliperelman commented Aug 8, 2017

Hey @tj, depending on what your preset or RC file looks like:

module.exports = neutrino => {
  neutrino.config.output.publicPath('/');
};

Or

module.exports = {
  use: [
    'neutrino-preset-react',
    neutrino => neutrino.config.output.publicPath('/')
  ]
};

Something like that should work. Lemme know!

@tj
Copy link

tj commented Aug 8, 2017

Thanks man! I'll give that a try

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants