Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Update dependency eslint-plugin-node to v11 #1513

Merged
merged 1 commit into from
Jan 4, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 27, 2019

This PR contains the following updates:

Package Type Update Change
eslint-plugin-node dependencies major ^10.0.0 -> ^11.0.0

Release Notes

mysticatea/eslint-plugin-node

v11.0.0

Compare Source

💥 Breaking changes

  • b6cb9a0 updated node/no-unsupported-features/node-builtins rule based on Node.js 13.2.0.
  • fb9ce15 updated node/no-unsupported-features/es-syntax rule to recognize BigInt literal property names.
  • 4295f6a updated the rules that check global variables to recognize globalThis.*.
  • 04051ed updated node/no-unsupported-features/es-builtins rule to recognize globalThis.

✨ Enhancements

  • 276a9ad updated node/no-deprecated-api rule to allow revoked deprecations.
  • 972f828 updated node/no-unsupported-features/node-builtins rule to handle backporting properly.

🐛 Bug fixes

  • 4f74fbf fixed a crash bug around dynamic import syntax.

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.

@edmorley
Copy link
Member

Reading the diffs I disagree that the changes listed as breaking are actually breaking. We don't support node.js 8 (which was one of the things dropped that might be why they are calling it breaking), and the rest of the changes are more about fixing support for something that was previously handled correctly. The closest thing to a breaking change is that projects that were using globalThis to mean something else may now see lint warnings/errors, however (a) the naming was specifically chosen so that no significant projects used that name, (b) better to find out now rather than hit strange issues in the future.

As such, unless there are any objections, I'll land this as a non-breaking change in Neutrino 9.

@edmorley edmorley requested a review from a team December 28, 2019 19:03
@edmorley
Copy link
Member

edmorley commented Jan 3, 2020

As such, unless there are any objections, I'll land this as a non-breaking change in Neutrino 9.

Any last comments before I merge? :-)

@timkelty
Copy link
Contributor

timkelty commented Jan 3, 2020

@edmorley at a quick glance LGTM!

@edmorley edmorley merged commit 1fcf480 into master Jan 4, 2020
@edmorley edmorley deleted the renovate/eslint-plugin-node-11.x branch January 4, 2020 06:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants