Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

chore: Update dependency webpack to v5 #1674

Closed
wants to merge 14 commits into from
Closed

Conversation

Nic128
Copy link
Contributor

@Nic128 Nic128 commented Jul 12, 2021

#1624

Let's try webpack 5 again, at this point every plugin/loader have compatibility. This PR contains the content from these two branches.

TODO:

Alternative, we could release v10 alpha. One step in the v10 milestone, figure it out as we go. https://github.com/neutrinojs/neutrino/milestone/7

@edmorley
Copy link
Member

edmorley commented Sep 8, 2021

Hi! Thank you for the PR.

In order to move this forwards:

  1. CI on this repo needs migrating away from Travis CI (since there are no credits left) - there is a WIP in GitHub actions #1663 but it has stalled
  2. webpack-chain needs webpack 5 support first

@Nic128
Copy link
Contributor Author

Nic128 commented Sep 9, 2021

Ported the CI changes from #1663.

@edmorley
Copy link
Member

edmorley commented Sep 9, 2021

Ported the CI changes from #1663.

Thank you for looking at the CI changes. Could you move them to their own PR? I'm a fan of keeping PRs to be about one change at a time, and this PR is already pretty large (+1,104 −1,304) :-)

@Nic128
Copy link
Contributor Author

Nic128 commented Sep 9, 2021

Created a new PR with just the CI changes. #1675

@Nic128
Copy link
Contributor Author

Nic128 commented Sep 9, 2021

It's possible some of the compilation problem I'm having will be solved when webpack-chain gets the webpack 5 support.

packages/karma/index.js Outdated Show resolved Hide resolved
@Nic128
Copy link
Contributor Author

Nic128 commented Sep 10, 2021

The VueLoaderPlugin problem is eluding me. I'll need help. Hopefully, when upgrading webpack-chain, it'll resolve itself.

Edit: Upgrading webpack-chain is not the problem.

@Nic128 Nic128 force-pushed the feat/v10 branch 2 times, most recently from 8671430 to d7078aa Compare October 4, 2021 13:55
@Nic128
Copy link
Contributor Author

Nic128 commented Oct 4, 2021

Got passed the vue-loader problem.

@Nic128
Copy link
Contributor Author

Nic128 commented Oct 4, 2021

@edmorley The pipeline is now green, please review.

@edmorley
Copy link
Member

@Nic128 Sorry for the delay - busy + I don't use this project any more.

As mentioned in #1674 (comment) a pre-requesite for adding support for webpack 5 to Neutrino, is for webpack-chain to support webpack 5 first.

That work is being tracked here (help needed, since I won't be working on it):
https://github.com/neutrinojs/webpack-chain/milestone/1

Many thanks!

@Nic128
Copy link
Contributor Author

Nic128 commented Oct 28, 2021

I have forked/published this branch for my own private usage and found bugs along the way. I'll update this PR when I find them.

@edmorley
Copy link
Member

edmorley commented Feb 3, 2024

Closing since unfortunately this project is no longer maintained. See:
#1707
neutrinojs/webpack-chain#358

@edmorley edmorley closed this Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants