This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
neutrino-middleware-image-loader: Use svg-url-loader for svg rule #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 90.66% 90.69% +0.02%
==========================================
Files 36 36
Lines 418 419 +1
==========================================
+ Hits 379 380 +1
Misses 39 39
Continue to review full report at Codecov.
|
eliperelman
suggested changes
Apr 7, 2017
| .use('url') | ||
| .loader(urlLoader) | ||
| .options({ limit, mimetype: 'image/svg+xml' }); | ||
| .use('svgUrl') |
There was a problem hiding this comment.
We can actually probably just leave this .use as url. It's still a URL "loader", even though the actual loader is different. The .use call just defines the ID of the loader.
There was a problem hiding this comment.
Yep, wondered about that.
Change pushed.
eliperelman
approved these changes
Apr 7, 2017
|
Released in v5.4.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because base64 encoding SVG content doesn't make sense.