Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Adding getters and setters for path options, options for middleware #176

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Adding getters and setters for path options, options for middleware #176

merged 1 commit into from
Apr 12, 2017

Conversation

eliperelman
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 11, 2017

Codecov Report

Merging #176 into master will increase coverage by 0.56%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   90.69%   91.26%   +0.56%     
==========================================
  Files          36       36              
  Lines         419      492      +73     
==========================================
+ Hits          380      449      +69     
- Misses         39       43       +4
Impacted Files Coverage Δ
packages/neutrino-middleware-font-loader/index.js 88.88% <0%> (-11.12%) ⬇️
packages/neutrino-middleware-image-loader/index.js 88.88% <0%> (-11.12%) ⬇️
packages/neutrino/test/api_test.js 100% <100%> (ø) ⬆️
packages/neutrino-middleware-html-loader/index.js 100% <100%> (ø) ⬆️
packages/neutrino/src/api.js 98% <100%> (+0.63%) ⬆️
packages/neutrino-middleware-minify/index.js 100% <100%> (ø) ⬆️
packages/neutrino-middleware-style-loader/index.js 33.33% <33.33%> (-66.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c1dfb...7402841. Read the comment docs.

@timkelty
Copy link
Contributor

Tested setting source, output, and entry with relative paths from middleware - works for me!

I'm not sure how important it is - but it seems there still isn't really a good way to (re)set the defaults, but still allow overrides from package.json.

@eliperelman eliperelman merged commit 957645f into neutrinojs:master Apr 12, 2017
@timkelty
Copy link
Contributor

Thanks! Eagerly awaiting a release :)

@eliperelman
Copy link
Member Author

@timkelty it's already released, in v5.5.0! 🎉

@timkelty
Copy link
Contributor

BOSS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants