Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Feature/universal entry #195

Merged
merged 4 commits into from
May 2, 2017
Merged

Feature/universal entry #195

merged 4 commits into from
May 2, 2017

Conversation

constgen
Copy link
Contributor

@constgen constgen commented May 1, 2017

Resolves #188

@eliperelman
Copy link
Member

@codecov
Copy link

codecov bot commented May 2, 2017

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   94.14%   94.14%           
=======================================
  Files          36       36           
  Lines         512      512           
=======================================
  Hits          482      482           
  Misses         30       30
Impacted Files Coverage Δ
packages/neutrino/src/api.js 98% <100%> (ø) ⬆️
packages/neutrino/test/api_test.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7688dc...a73d8b2. Read the comment docs.

@constgen
Copy link
Contributor Author

constgen commented May 2, 2017

I have commited changes like you asked. But I failed to test it locally
image

Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; also the test passes in Travis, so works for me. My guess is it's something Windows related. :/

@eliperelman eliperelman merged commit 9d7029f into master May 2, 2017
@eliperelman
Copy link
Member

Released in v5.8.0.

@constgen constgen deleted the feature/universal-entry branch May 8, 2017 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants