Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Add babel-plugin-istanbul to ensure accurate coverage is reported. #279

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Add babel-plugin-istanbul to ensure accurate coverage is reported. #279

merged 1 commit into from
Jun 23, 2017

Conversation

jaridmargolin
Copy link
Contributor

Prior to this PR, coverage reports were generated, but contained no actual content.

Reference: https://github.com/istanbuljs/babel-plugin-istanbul

eliperelman
eliperelman approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliperelman
Copy link
Member

Since yarn is broken in Travis, I'll merge these and ensure linting and tests pass before releasing.

@eliperelman eliperelman merged commit 4846888 into neutrinojs:master Jun 23, 2017
@edmorley
Copy link
Member

Since yarn is broken in Travis,

I doubt there will be a quick fix, so I'd do:
mozilla/treeherder@7f20e37

@eliperelman eliperelman mentioned this pull request Oct 31, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eliperelman eliperelman eliperelman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaridmargolin @eliperelman @edmorley