This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add an .npmignore to all packages #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excluding the test directory and `yarn.lock` reduces the package size significantly (for example 85-90% reduction in both compressed and uncompressed size of neutrino-preset-web), plus reduces the noise when consumers need to grep their local `node_modules`. An `.npmignore` has been used instead of the `files` directive in `package.json` since the latter can cause breakage that isn't shown in CI if the directory layout changes (which is likely given the Neutrino packages have a mixture of using the `src` directory and not, depending on how many files they include). `.npmignore` was used instead of `.yarnignore` since npm doesn't support the latter whereas yarn supports both.
|
Wow, that much of a reduction?! 😮 |
eliperelman
approved these changes
Jun 29, 2017
|
Yeah - yarn.lock is quite big in comparison to the actual middleware/presets! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excluding the test directory and
yarn.lockreduces the package size significantly (for example 85-90% reduction in both compressed and uncompressed size of neutrino-preset-web), plus reduces the noise when consumers need to grep their localnode_modules.An
.npmignorehas been used instead of thefilesdirective inpackage.jsonsince the latter can cause breakage that isn't shown in CI if the directory layout changes (which is likely given the Neutrino packages have a mixture of using thesrcdirectory and not, depending on how many files they include)..npmignorewas used instead of.yarnignoresince npm doesn't support the latter whereas yarn supports both.Fixes #289.