Remove unused dependencies #339
Conversation
The `eslint-config-airbnb-base` and `eslint-plugin-import` packages are not used by `neutrino-middleware-eslint` itself, but instead by `neutrino-preset-airbnb-base`.
Of note: * `webpack-dev-middleware` can be removed from the karma preset, since it's only used by `karma-webpack` which already has it as a dependency. * `webpack-dev-server` can be removed from the web preset since it's a leftover from when `neutrino-middleware-dev-server` was created. * the web preset's `core-js` and `babel-polyfill` dependencies are leftover from #315. Everything else was manually determined to be unused via correlating the package list against greps of the source, plus checking that the package wasn't a peer dependency of another listed package.
| "fluture": "^7.1.3", | ||
| "lodash.clonedeep": "^4.5.0", | ||
| "ramda": "^0.24.1" | ||
| }, | ||
| "devDependencies": { | ||
| "eslint-config-airbnb-base": "^12.0.1" |
There was a problem hiding this comment.
In the past the reason this devDependency existed had to do with local development and linking. ESLint didn't like to resolve where this package existed for the Airbnb preset when you linked it, probably due to the nested node_modules structure. My guess is that problem still exists, but can probably be fixed if we move to yarn workspaces and hoisted deps.
There was a problem hiding this comment.
I agree there is a bug in yarn where it's over-eager to complain about "missing" peer deps (I'm going to file that separately). However in this case, the devDependency was actually in the wrong package - it's airbnb base that's using it :-)
There was a problem hiding this comment.
Yeah, that's what I mean. When you link neutrino-preset-airbnb-base, ESLint couldn't resolve eslint-config-airbnb-base because the eslint binary lives in neutrino-middleware-eslint but it was trying to use a working directory relative to neutrino-preset-airbnb-base.
There was a problem hiding this comment.
Ah yeah that makes sense. I thought you meant a related bug that I ran into, where yarn outputs "missing peer" for a case that npm doesn't.
I'm looking forward to yarn workspaces working well and all of this going away! :-)
|
Released in v7.0.2. |
There are a few 7.0.1 version references that escaped being updated to 7.0.2: I don't know if this matters at all? |
|
For major versions it would definitely matter, for patches and minors probably not, but this is definitely wrong. Maybe it's a race condition between the publish of dependencies and the updating of them in package.json. |
I've filed yarnpkg/yarn#4675 for this other case. |
1) Moves preset-airbnb-base dependencies out of middleware-eslint
The
eslint-config-airbnb-baseandeslint-plugin-importpackages are not used byneutrino-middleware-eslintitself, but instead byneutrino-preset-airbnb-base.2) Removes unused dependencies
webpack-dev-middlewarecan be removed from the karma preset, since it's only used bykarma-webpackwhich already has it as a dependency.webpack-dev-servercan be removed from the web preset since it's a leftover from whenneutrino-middleware-dev-serverwas created.core-jsandbabel-polyfilldependencies are leftover from Upgrading Webpack to v3, merge config as middleware #315.The yarn.lock comment changes are because I'm using an up to date version of yarn that no longer adds the version numbers to the lockfile (which aims to reduce lock file churn due to version differences). Hopefully shortly we'll be on a newer yarn everywhere, thereby avoiding this.