Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Feature: upgrade webpack-chain to use .before() and .after() #346

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Feature: upgrade webpack-chain to use .before() and .after() #346

merged 1 commit into from
Oct 6, 2017

Conversation

eliperelman
Copy link
Member

No description provided.

Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This will help one of Treeherder's use-cases too :-)

@@ -523,37 +528,37 @@ _NOTE: Do not use `new` to create the plugin, as this will be done for you._
```js
neutrino.config
.plugin(name)
.use(WebpackPlugin, args)
.use(WebpackPlugin, args)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these indentation fixes are also applicable to the upstream webpack-chain docs and could be upstreamed at some point :-) (I'm using DiffMerge to do partial line comparisons between the two)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grr, I thought I caught all those there. 😭

@eliperelman eliperelman merged commit 3aa2666 into neutrinojs:master Oct 6, 2017
@eliperelman
Copy link
Member Author

Released in v7.1.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants