Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Use latest version of yarn on Travis #355

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Use latest version of yarn on Travis #355

merged 1 commit into from
Oct 10, 2017

Conversation

edmorley
Copy link
Member

The only remaining error with oao + recent yarn turned out to be due to OOM (guigrpa/oao#51), which can be solved by switching to Travis' fully virtualised infra, which has more RAM.

The --frozen-lockfile parameter has also been moved to .travis.yml so that the lockfiles are still updated when working making changes locally.

Being on latest yarn makes it a lot easier to experiment with switching to yarn workspaces and/or lerna.

The only remaining error with oao + recent yarn turned out to be due
to OOM (guigrpa/oao#51), which can be solved
by switching to Travis' fully virtualised infra, which has more RAM.

The `--frozen-lockfile` parameter has also been moved to `.travis.yml`
so that the lockfiles are still updated when working making changes
locally.
@edmorley edmorley self-assigned this Oct 10, 2017
@@ -1,3 +1,8 @@
# Use the fully virtualised infra not for sudo, but since their container
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/, but//

Copy link
Member Author

@edmorley edmorley Oct 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That changes the meaning to the opposite of the what it's intending to say.

To explain in another way - Travis has two trusty based stacks:

  • container (sudo: false): no-sudo, less RAM
  • fully virtualised (sudo: required): has sudo, more RAM, few other differences

Much of the time people use the latter because of the need to use sudo commands rather than because of the difference in machine specifications, which is why Travis use the sudo: {false,required} setting to control which environment is used.

However in this case, the need for sudo commands is not why we're setting sudo: required, it's because we want the higher spec fully virtualised environment.

I'm open to suggestions to another way of wording that makes that clearer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No no, I was just confused as to why travis configures it this way. Proceed. 😄

# infra's 4GB of RAM is not sufficient to prevent yarn bootstrap OOMs:
# https://github.com/guigrpa/oao/issues/51
# https://docs.travis-ci.com/user/reference/overview/#Virtualization-environments
sudo: required
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need sudo?

@edmorley edmorley merged commit 3d495a8 into neutrinojs:master Oct 10, 2017
@edmorley edmorley deleted the yarn-latest branch October 10, 2017 23:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants