Remove extra keys that are invalid in eslintrc #358
Conversation
| "yarn lint --fix", | ||
| "git add" | ||
| ], | ||
| "packages/neutrino/bin/neutrino": [ |
There was a problem hiding this comment.
Should this be .../bin/* for parity with the include entry in .neutrinorc.js ?
There was a problem hiding this comment.
Everything in bin is already caught by *.js previously, so I thought this would cover the only other file.
| @@ -15,8 +15,7 @@ const reduceToTrueKeys = reduce((acc, key) => assoc(key, true, acc), {}); | |||
| const getEslintRcConfig = pipe( | |||
| getEslintOptions, | |||
| clone, | |||
| assoc('useEslintrc', true), | |||
| omit(['failOnError', 'emitWarning', 'emitError']), | |||
| omit(['failOnError', 'emitWarning', 'emitError', 'cwd', 'useEslintrc', 'fix', 'extensions']), | |||
There was a problem hiding this comment.
I wonder if we should add a comment explaining why some keys are omitted and linking to:
https://github.com/eslint/eslint/blob/master/conf/config-schema.js
(Used by: https://github.com/eslint/eslint/blob/9d1df92628dd4dd1e70fbb19454008e146387435/lib/config/config-validator.js#L167 )
|
@edmorley I like that idea! I've implemented something rudimentary that should be usable by Travis. |
|
The Travis tests look great! Could you also add the new |
Fixes #356.