This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Improve error messaging for middleware used with no entry point #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
reviewed
Oct 30, 2017
|
@edmorley I added a test, but in doing so changed a few things. I didn't want to put references to the CLI in an error generated by the API, so I made it generic, then re-handled in the CLI. To make this consistent across all commands, I made each CLI command call a common base which removes a lot of the boilerplate that every command was doing. Hopefully this brings more simplicity and consistency to our handling from the CLI. |
|
Even better! :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #384.