Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Add font, image options. #467

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Conversation

timkelty
Copy link
Contributor

Adds a couple more options, allows exclusion with false.

Related: what do you think about grouping these under options.loaders?

  const options = merge({
    env: [],
    hot: true,
    html: {},
    publicPath: './',
    devServer: {
      hot: opts.hot !== false
    },
    polyfills: {
      async: true
    },
    minify: {},
    manifest: {},
    babel: {},
    targets: {},
    loaders: {
      html: {},
      font: {},
      image: {},
      style: {
        hot: opts.hot !== false
      }
    }
  }, opts);

Might not be necessary, but could clear up confusion (e.g. options.html vs options.loaders.html)

@eliperelman
Copy link
Member

Using the term loaders alludes to a structure that is used internally by the preset, but which the user may not necessarily care about. I'd like to keep these top-level if possible.

Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add these options to the docs?

@edmorley
Copy link
Member

LGTM with docs additions :-)

@timkelty
Copy link
Contributor Author

Yep, I'll add docs.

@timkelty
Copy link
Contributor Author

Ok docs added.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants