Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Allow using a custom entry for Node.js preset #469

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Allow using a custom entry for Node.js preset #469

merged 2 commits into from
Nov 21, 2017

Conversation

eliperelman
Copy link
Member

Fixes #468.

@eliperelman eliperelman requested a review from a team November 21, 2017 15:20
edmorley
edmorley approved these changes Nov 21, 2017
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a test for this be easy? (Given our minimal tests so far)

@edmorley
Copy link
Member

I wonder as well whether we should do this for the web preset too? For multi-entrypoint support I guess we'll need to.

@eliperelman
Copy link
Member Author

Would a test for this be easy? (Given our minimal tests so far)

I'll have a look to see.

I wonder as well whether we should do this for the web preset too? For multi-entrypoint support I guess we'll need to.

My thoughts exactly, and I was working to incorporate these into master.

@eliperelman
Copy link
Member Author

Added test for custom entry.

@eliperelman eliperelman merged commit 0f46c00 into neutrinojs:release/v7 Nov 21, 2017
@eliperelman eliperelman mentioned this pull request Nov 21, 2017
Closed
@Franckins Franckins mentioned this pull request Mar 22, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliperelman @edmorley