This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
add eslint-jest-plugin #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
suggested changes
Feb 24, 2017
| @@ -65,6 +65,14 @@ module.exports = neutrino => { | |||
| }; | |||
| }); | |||
|
|
|||
| neutrino.config.module | |||
There was a problem hiding this comment.
It isn't known for sure whether a linting rule has been added, so this needs to be wrapped in a conditional.
if (neutrino.config.rules.has('lint')) {| options: merge(options, { | ||
| plugins: ['jest'] | ||
| }) | ||
| })) |
| @@ -65,6 +65,14 @@ module.exports = neutrino => { | |||
| }; | |||
| }); | |||
|
|
|||
| neutrino.config.module | |||
| .rule('lint') | |||
| .loader('eslint', ({ options }) => ({ | |||
There was a problem hiding this comment.
I know I've established the pattern elsewhere, but I'm currently changing it. Could you move the merge here to the top level?
.loader('eslint', props => merge(props, {| @@ -19,6 +19,7 @@ | |||
| "babel-plugin-transform-es2015-modules-commonjs": "^6.22.0", | |||
| "babel-preset-jest": "^18.0.0", | |||
| "deepmerge": "^1.3.2", | |||
| "eslint-plugin-jest": "^19.0.1", | |||
There was a problem hiding this comment.
Does this plugin version support the version of Jest we are using here? Jest 19 was recently released but we can't yet switch to it because it's a breaking change.
There was a problem hiding this comment.
This plugin only turns on/off some configs of ESLint, it only depends on ESlint package.
Check it's package.json for some details.
eliperelman
approved these changes
Feb 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review
https://www.npmjs.com/package/eslint-plugin-jest