Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fix inconsistencies in the react and preact docs #483

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Fix inconsistencies in the react and preact docs #483

merged 1 commit into from
Nov 28, 2017

Conversation

eliperelman
Copy link
Member

@eliperelman eliperelman commented Nov 21, 2017 •
edited
Loading

Fixes #473.

@edmorley
Copy link
Member

Fixes #473.

This will close that issue, but there were also a few non-docs changes too (eg missing .npmignore, differences in the way the babel options are merged)? :-)

@eliperelman eliperelman changed the title Fix consistencies in the react and preact docs Fix inconsistencies in the react and preact docs Nov 27, 2017
@eliperelman
Copy link
Member Author

@edmorley I've added the npmignore, but the merging of babel options is different because of the ordering of react-hot-loader, which is different from the way the preact preset works.

@eliperelman eliperelman merged commit 9dbe8f5 into neutrinojs:master Nov 28, 2017
@eliperelman eliperelman mentioned this pull request Dec 6, 2017
Merged
3 tasks
@Franckins Franckins mentioned this pull request May 22, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
docs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliperelman @edmorley