-
Notifications
You must be signed in to change notification settings - Fork 213
Use Neutrino's extensions in the rest of packages #497
Use Neutrino's extensions in the rest of packages #497
Conversation
I grepped the following usages of "extensions":
|
be7a2ed
to
4da46ba
Compare
Webstorm didn't do a good job at grepping. @eliperelman I started using ag for searching files. Amazing tool. It ignores everything listed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current changes are good, but I also noticed when trying to rebase my create-project PR that I needed to update the calls to .test()
for some items.
Grep for all the usages of .test()
and see if they need to be replaced with something like:
.test(options.test || neutrino.regexFromExtensions())
I left .test(/\.module.css$/) untouched because .css is not in the default list and it is also presently under work (css modules not working).
@@ -46,7 +46,7 @@ neutrino.use(eslint, { | |||
cwd: neutrino.options.root, | |||
useEslintrc: false, | |||
root: true, | |||
extensions: ['js', 'jsx'], | |||
extensions: neutrino.options.extensions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means eslint will now be run against .json
files too. Is this intended? (For example if people have the "enforce trailing commas" eslint rule enabled, eslint will complain unless the .json is changed to be invalid)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we tested that this really happens? That would be weird! It would also mean single quote properties and values would also break...I guess we should find out. If it does, we can filter json
from the list. Good catch.
No description provided.