This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Simplify react-components to building instead of dictating preview app #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really a breaking change since this isn't released. If this had been released, it would be breaking. 😺 |
timkelty
pushed a commit
to timkelty/neutrino
that referenced
this pull request
Dec 7, 2017
neutrinojs#559) * Simplify react-components to building instead of dictating preview app * Remove react-component app scaffolding from create-project
timkelty
pushed a commit
to timkelty/neutrino
that referenced
this pull request
Dec 7, 2017
neutrinojs#559) * Simplify react-components to building instead of dictating preview app * Remove react-component app scaffolding from create-project
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining the react previewer components just seemed to muddy up the preset, and prevented users from using their own custom previewer preferences. This PR removes our opinion, leaving the choice to the user.