This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Web: Handle booleans for options.minify, options.style, options.style.extract #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkelty
changed the title
options.minify
timkelty
changed the title
timkelty
changed the title
|
Holler if theres anything more I can do to get this merged! 💯 |
|
Would appreciate any eyes from @mozilla-neutrino/core-contributors to move this along and get it merged! |
timkelty
added a commit
to timkelty/neutrino
that referenced
this pull request
Jan 17, 2018
….extract (neutrinojs#601) * Allow overriding of `options.minify`. * Only add in production * Simplify extract defaults. * Fix tests, reverse merge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to completely disable
@neutrinojs/minify,@neutrinojs/styleby passingfalseto their respective options.Also included is the coercion of
options.style.extractto{}, when passedtrue.