This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fix issue where ES6 won't compile with Jest and Neutrino v8 #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
reviewed
Dec 19, 2017
packages/jest/src/index.js
Outdated
| const jsNames = neutrino.regexFromExtensions(['js', 'jsx']); | ||
| const mediaNames = `\\.(${mediaExtensions.join('|')})$`; | ||
| const styleNames = `\\.(${['css', 'less', 'sass', 'scss'].join('|')})$`; | ||
| const jsNames = `\\.(${['js', 'jsx'].join('|')})$`; |
There was a problem hiding this comment.
We still want to use the stored Neutrino extensions, so probably something like:
`\\.(${[...neutrino.options.extensions].join('|')})$`;
There was a problem hiding this comment.
I think we should also add a comment explaining why we're not using regexFromExtensions() :-)
|
Applied this patch to my local install and it worked great with v8. Thanks for the quick fix. Excited to start using neutrino for vx |
eliperelman
approved these changes
Dec 21, 2017
|
Looks great! |
timkelty
pushed a commit
that referenced
this pull request
Dec 21, 2017
* Fix issue where ES6 won't compile with Jest and Neutrino v8 * Use neutrino.options.extensions to cover additional extensions
timkelty
pushed a commit
to timkelty/neutrino
that referenced
this pull request
Jan 17, 2018
…js#640) * Fix issue where ES6 won't compile with Jest and Neutrino v8 * Use neutrino.options.extensions to cover additional extensions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #638.