Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Update dependency stylelint to ^9.0.0 #710

Merged
merged 1 commit into from
Mar 24, 2018
Merged

Update dependency stylelint to ^9.0.0 #710

merged 1 commit into from
Mar 24, 2018

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 18, 2018 •
edited
Loading

This Pull Request updates dependency stylelint from ^8.0.0 to ^9.0.0

Release Notes

v9.0.0

  • Removed: Node.JS 4.x support. Node.js 6.x or greater is now required (#​3075).
  • Added: (experimental) support for SASS syntax (#​2503).
  • Added: allow processors to handle PostCSS errors (#​3063).
  • Added: --max-warnings CLI flag (#​2942).
  • Added: selector-combinator-*list rules (#​3088).
  • Added: selector-pseudo-element-*list rules (#​3104).
  • Added: ignore: ["first-nested"] to custom-property-empty-line-before (#​3104).
  • Added: ignore: ["first-nested"] to declaration-empty-line-before (#​3103).
  • Added: ignoreProperties: [] to property-no-vendor-prefix (#​3089).
  • Fixed: font-family-name-quotes unicode range increased (#​2974).
  • Fixed: selector-max-id in nested at-statements (#​3113).

v9.1.0

  • Added: ignore: ["first-nested"] to at-rule-empty-line-before (#​3179).
  • Added: ignore: ["first-nested"] to rule-empty-line-before (#​3179).
  • Fixed: unnecessary Open Collective postinstall message (#​3180).

v9.1.1

  • Fixed: missing signal-exit dependency (#​3186).

v9.1.2

  • Fixed: parsing of markdown files by updating postcss-html dependency (#​3207).

v9.1.3

  • Fixed: invalid HTML causing CssSyntaxError by updating postcss-html dependency (#​3214).
  • Fixed: empty markdown block causing CssSyntaxError by updating postcss-html dependency (#​3214).
Commits

v9.0.0

  • 5d79418 Add Node.js 9 to Travis CI (#​2999)
  • 07b4480 Use write-file-atomic for writing fixed styles to filesystem (#​2992)
  • e1b2332 Update Prettier (#​3071)
  • 5dc5db5 Update/flow typed definitions (#​3074)
  • b4b6d19 chore(package): update eslint to version 4.14.0 (#​3079)
  • ef15f25 chore(package): update flow-bin to version 0.62.0 (#​3084)
  • c7c964f chore: Update Lodash Flow library definitions (#​3086)
  • e13edab Update license date (#​3090)
  • e7da2a0 Add ignoreProperties to property-no-vendor-prefix (#​3089)
  • b10d384 Update CHANGELOG.md
  • 4d53e92 Update eslint-config-stylelint to v8.1.0 (#​3097)
  • f38bd78 Update PostCSS to v6.0.15 (#​3096)
  • bcb46b7 Bump minimum required Node.js version to 6 and drop 4.x (#​3075)
  • c7b04a0 Update CHANGELOG.md
  • b57467e Update CHANGELOG.md
  • 10de360 Add Table of Contents marker to docs (#​3100)
  • b38a9fc Add ignore: ["first-nested"] to declaration-empty-line-before (#​3103)
  • 65e8b36 Update CHANGELOG.md
  • 1acb588 Add ignore: ["first-nested"] to custom-property-empty-line-before (#​3104)
  • 1a6f484 Update CHANGELOG.md
  • 4c90af5 Add selector-pseudo-element-*list rules (#​3087)
  • c33f353 Add --max-warnings cli flag (fixes #​2939) (#​2942)
  • 9a8f4c1 Update CHANGELOG.md
  • b2712de Update CHANGELOG.md
  • 66f0ad6 Add selector-combinator-*list rules (#​3088)
  • 741cd6e Update CHANGELOG.md
  • 1f611bd chore(package): update eslint to version 4.15.0 (#​3109)
  • 0dde16d Address PostCSS console warnings (#​3110)
  • 5da6cf3 Update flow-bin to the latest version 🚀 (#​3108)
  • 661a789 Removed erroneous violation entry (#​3116)
  • fa75978 chore(package): update prettier to version 1.10.0 (#​3120)
  • a053815 Fix selector-max-id tests (#​3122)
  • 7a67e09 chore: Bump Jest to 22.0.6 (#​3121)
  • 035329a Run Jest in parallel (#​3081)
  • b8a9491 Activating Open Collective (#​2955)
  • 4e7658a Add jest:detectleaks npm script for Jest memory leak testing. (#​3123)
  • 897e241 chore: Update Jest Flow library definitions (#​3125)
  • 38a4bc3 Let processors modify the stylelintResult in case of CssSyntaxError (#​3063)
  • a2432f3 Update CHANGELOG.md
  • 3bd6a59 Update greenkeeper label (#​3126)
  • fbdd4ac fix(package): update cosmiconfig to version 4.0.0 (#​3129)
  • 207c662 Added support for sass syntax (#​2503)
  • 793dd73 Update CHANGELOG.md
  • 05a3883 Update eslint to the latest version 🚀 (#​3136)
  • b8d6dcb Update remark-cli to the latest version 🚀 (#​3137)
  • 7add4c2 Fix high-range unicode characters in font-family-name-quotes (#​2977)
  • 38a90a1 Update CHANGELOG.md
  • 46e7f83 chore: Add a npm script to help update flow-type definitions (#​3142)
  • 09c57a0 Update flow-bin to the latest version 🚀 (#​3141)
  • a9aad29 Add SASS related content to the document (#​3138)
  • 442b675 Update known-css-properties to the latest version 🚀 (#​3149)
  • 030612b Update eslint to the latest version 🚀 (#​3150)
  • 8a6d344 Added 'sass' keyword to package.json (#​3152)
  • 53e8e4b Update flow-bin to the latest version 🚀 (#​3157)
  • 152f920 Bugfix/issue#​3105 selector max id nested at statements (#​3113)
  • 1cdd64a Update CHANGELOG.md
  • d5d53b1 Update CHANGELOG.md
  • fce4456 Add link to stylelint-react-native (#​3162)
  • 247036f Update autoprefixer to the latest version 🚀 (#​3163)
  • 1eb07c9 Expand documentation of declaration-block-no-redundant-longhand-prope… (#​3165)
  • a5e2a96 chore(package): update eslint to version 4.18.0 (#​3170)
  • 27fde11 chore(package): update flow-bin to version 0.66.0 (#​3169)
  • 2a5f009 chore: Update Flow library definitions (#​3174)
  • c26256f Make CHANGELOG consistent
  • a145849 Prepare 9.0.0

v9.1.0

  • a6496bd Fix Readme contributors link (#​3177)
  • 4d75991 Remove Open Collective postinstall message (#​3180)
  • 173a090 Add ignore: ["first-nested"] options (#​3179)
  • a06dfb5 Update CHANGELOG.md
  • a012f51 Prepare 9.1.0

v9.1.1

  • 206fd48 Move signal-exit from devDependencies to dependencies. Fixes #​3185 (#​3186)
  • 6d56caa Update CHANGELOG.md
  • bee4576 Prepare 9.1.1

v9.1.2

  • 434cf46 docs: add stylelint-processor-glamorous to processors list (#​3187)
  • 31e3b27 Use default greenkeeper label (#​3188)
  • 23be9ae Update lint-staged to the latest version 🚀 (#​3184)
  • be4361e Update prettier to the latest version 🚀 (#​3191)
  • 8581bbf Update downloads badge to point to graph of downloads over time 📈 instead of duplicating link to npm (#​3193)
  • 8a82ea3 fix(package): update postcss-html to version 0.13.0 (#​3202)
  • 1b85c54 Add link to stylelint-selector-tag-no-without-class plugin (#​3201)
  • eac239c Add link to stylelint-z-index-value-constraint plugin (#​3205)
  • 9c4f8ff fix(package): update postcss-html to version 0.14.0 (#​3207)
  • 674d93d Update CHANGELOG
  • 79b2721 Prepare 9.1.2

v9.1.3

  • 28b7a0b fix(package): update postcss-html to version 0.15.0 (#​3214)
  • 820f403 Add description of Sass to CLI (#​3215)
  • d187cc6 Update CHANGELOG
  • c54fccd Prepare 9.1.3

This PR has been generated by Renovate Bot.

@edmorley
Copy link
Member

edmorley commented Mar 9, 2018

So whilst this is a major version bump, it seems like the only real breaking change is dropping node 4, which we don't support anyway. As such, it seems ok to ship in Neutrino 8.x.

@timkelty, thoughts?

@edmorley edmorley requested a review from timkelty March 9, 2018 20:33
@edmorley
Copy link
Member

The changelog is:
stylelint/stylelint@8.4.0...9.1.1

One of the changes is updating autoprefixer:
stylelint/stylelint@247036f

Whose changelog is here:
https://github.com/postcss/autoprefixer/blob/master/CHANGELOG.md#80-excelsior

It's not clear to me if this would cause new lint errors to appear that didn't before.

I guess linters are a tricky one, since normally a "new feature" would mean a minor version bump, but for a linter if that feature is enabled by default and could cause new failures, that actually makes it a major version bump.

@renovate renovate bot force-pushed the renovate/stylelint-9.x branch 2 times, most recently from ca7812d to 4e6fa93 Compare March 10, 2018 18:27
@edmorley edmorley merged commit b7f22f8 into master Mar 24, 2018
@edmorley edmorley deleted the renovate/stylelint-9.x branch March 24, 2018 00:30
@edmorley edmorley added this to the v9 milestone Apr 16, 2018
@edmorley
Copy link
Member

edmorley commented Apr 19, 2018 •
edited
Loading

Running yarn install on master currently gives:

warning "workspace-aggregator-b060b498-e6df-406a-af25-4ce0905bcb4e > @neutrinojs/stylelint > 
stylelint-webpack-plugin@0.10.4" has incorrect peer dependency "stylelint@^8.0.0".

Looking at webpack-contrib/stylelint-webpack-plugin#149 it seems like this isn't just cosmetic - stylelint-webpack-plugin is not actually compatible with stylelint v9 yet.

As such, I'll revert this for now.

There sadly doesn't appear to be a yarn option to say "exit with status 1 if there were peer dependency warnings" (and the yarn check command currently appears to be pretty broken with workspaces/...) - so for now we'll have to carefully vet the travis log for each major version upgrade (or else add a hacky grep check).

@edmorley edmorley mentioned this pull request Apr 19, 2018
Merged
edmorley added a commit that referenced this pull request Apr 19, 2018
@edmorley
Downgrade stylelint to ^8.0.0 (#804)
1e73fd0 
Since stylelint-webpack-plugin doesn't yet support v9:
webpack-contrib/stylelint-webpack-plugin#149

Reverts b7f22f8 (#710) and also
recreates the lockfile to clean up the spurious entries added by #794.
@edmorley edmorley removed this from the v9 milestone Apr 19, 2018
@brneto
Copy link

brneto commented Jun 1, 2018

@edmorley When are you thinking to upgrade dependency stylelint to ^9.0.0 again?

@edmorley
Copy link
Member

edmorley commented Jun 1, 2018

I'd love to now, but this is still blocked on webpack-contrib/stylelint-webpack-plugin#149. If you were able to help upstream update that would be awesome :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edmorley edmorley edmorley approved these changes

@timkelty timkelty Awaiting requested review from timkelty

Assignees
No one assigned
Labels
breaking change
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edmorley @brneto @renovate-bot