This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Update dependency eslint-loader to ^2.0.0 #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/eslint-loader-2.x
branch
from
f1a12a0 to
c8a11e4
Compare
|
The only breaking changes here are dropping support for node 4 and webpack 1, neither of which are supported by Neutrino 8. As such I think we can treat this as non-breaking - @eliperelman ? |
|
As long as it doesn't change the options we or our users pass to it. |
edmorley
approved these changes
Mar 9, 2018
There was a problem hiding this comment.
This looks fine to me:
webpack-contrib/eslint-loader@1.9.0...2.0.0
(The eslintPath change makes eslint-loader now respect that path when requiring formatter, which seems like a bug fix to me)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates dependency eslint-loader from
^1.9.0to^2.0.0Release Notes
v2.0.0eslintPathfor formatter (by @lmnsg in #195)Commits
v2.0.0
9e8dadbAdd eslint installation instructions (#185)961d177ci: Enable travis builds with webpack 3fd20ae3chore(package): Bump webpack to 3.3.080eef61docs(readme): Clarify cache option usage (#186)855cadcrefactor: Remove line delete config.cacheDirectory (#187)667baf3Merge pull request #188 from sudo-suhas/ci_test_webpack_374674d3README: Note on hot module replacement and emitWarning (#194)756330cUpdate README.md178763bFix CI with proper (full + up to date) yarn usageabc88bfBye codesponsor 😢0d3d6dd🤫 Stop usingthiskeyword in loader function80ba5a4Webpack 4 compatibility (#212)7e3c75bUpdate Travis Url (#213)3c1c296Respect userOptions.eslintPath (#195)1ed9dac2.0.0This PR has been generated by Renovate Bot.