Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Adjust Renovate configuration #739

Merged
merged 1 commit into from
Mar 11, 2018
Merged

Adjust Renovate configuration #739

merged 1 commit into from
Mar 11, 2018

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Mar 10, 2018

Makes Renovate:

  • refresh the lockfile every Monday (docs)
  • wait until the Travis run on the branch has completed before opening the PR (avoids the issue of opening a GitHub notification email only to find there isn't yet a Travis result to inform review; docs).
  • add a status check to its PRs, that warns if the package is still within the 24 hour period in which it could be unpublished (docs). This combined with :prNotPending has an added bonus of reducing noise if a release was broken and then fixed within the 24 hour period.

(The newly added options are what we've been using on mozilla/treeherder for the last few months.)

Makes Renovate:
* refresh the lockfile every Monday
* wait until the Travis run on the branch has completed before opening
  the PR (avoids the issue of opening a GitHub notification email only
  to find there isn't yet a Travis result to inform review.
* add a status check to its PRs, that warns if the package is still
  within the 24 hour period in which it could be unpublished. This
  combined with `:prNotPending` has an added bonus of reducing noise
  if a release was broken and then fixed within the 24 hour period.
@edmorley edmorley self-assigned this Mar 10, 2018
Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@edmorley edmorley merged commit f598144 into neutrinojs:master Mar 11, 2018
@edmorley edmorley deleted the adjust-renovate-config branch March 11, 2018 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants