This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added coverage support to jest preset #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
reviewed
Feb 27, 2017
There was a problem hiding this comment.
Can you also add the associate flag to the neutrino bin and document it?
https://github.com/mozilla-neutrino/neutrino-dev/blob/master/docs/cli/README.md
|
@eliperelman Done |
eliperelman
suggested changes
Feb 28, 2017
| #### Yarn | ||
|
|
||
| ```bash | ||
| ❯ yarn test -- --coverage |
There was a problem hiding this comment.
This assumes that they are running the command via a package script, which may not always be true. Let's change these particular scripts to:
❯ neutrino test --coverageThen maybe mention something about a script target like:
{
"scripts": {
"coverage": "neutrino test --coverage"
}
}Thoughts?
| @@ -69,6 +69,7 @@ Options: | |||
| --presets A list of Neutrino presets used to configure the build [array] [default: []] | |||
| --version Show version number [boolean] | |||
| --help Show help [boolean] | |||
| --coverage Collect test coverage information and generate report [boolean] [default: false] | |||
| --watch Watch source files for changes and re-run tests [boolean] [default: false] | |||
| ``` | |||
|
|
|||
There was a problem hiding this comment.
Can you add a description of the --coverage flag at around line 95? The --watch flag has a similar description right above this.
eliperelman
approved these changes
Mar 1, 2017
|
Tested this locally, works great! Published this to npm for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.