-
Notifications
You must be signed in to change notification settings - Fork 214
Sort create-project dependencies and devDependencies #867
Conversation
create-project may be removed as part of #852 so cancelling the review for now |
Looks like we need a rebase here. |
6cc2348
to
07c6808
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sort order with this gives eg:
eslint, jest, neutrino, @neutrinojs/airbnb, @neutrinojs/jest, @neutrinojs/react, webpack, webpack-cli, webpack-dev-server
Looks neater, though I'm on the fence as to whether the added complexity of a custom sort function is worth it, since the default .sort()
would give:
@neutrinojs/airbnb, @neutrinojs/jest, @neutrinojs/react, eslint, jest, neutrino, webpack, webpack-cli, webpack-dev-server
...which is consistent with the package.json order, even if the neutrino deps aren't all consecutive.
Is up to you :-)
No strong feelings here. Feel free to close it if it's too much added complexity :) |
I don't mean close, I mean |
Resort to Array.prototype.sort instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks!
(Travis is failing - I believe due to a bug with either verdaccio or lerna when the auto-generated test package version SHA is numeric only and starting with a zero. I'll, try and track this down separately, but needn't block merging)
Resolves #853.