Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fix broken links in the docs #878

Merged
merged 1 commit into from
May 17, 2018
Merged

Fix broken links in the docs #878

merged 1 commit into from
May 17, 2018

Conversation

edmorley
Copy link
Member

Fixes #706 and several others found using a link checker site.

Some of these are about to be removed in the new-docs PR, however I plan on backporting this to the release/v8 branch.

Fixes #706 and several others found using a link checker site.

Some of these are about to be removed in the new-docs PR, however
I plan on backporting this to the `release/v8` branch.
@edmorley edmorley self-assigned this May 17, 2018
@edmorley edmorley requested a review from eliperelman May 17, 2018 19:22
@@ -50,7 +50,7 @@ the scaffolding phase.
| Test Runner | Middleware |
| --- | --- |
| Jest | [`@neutrinojs/jest`](../packages/jest) |
| Karma | [`@neutrinojs/karma`](../pakages/karma) |
| Karma | [`@neutrinojs/karma`](../packages/karma) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I know! 😭

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw mkdocs strict mode should avoid some of these in the future (though it will help less with the absolute neutrinojs.org URLs since it doesn't check those... though I guess we could make the build process convert them prior... then would solve both problems... I'll have a think).

@edmorley edmorley merged commit e6d1c71 into neutrinojs:master May 17, 2018
@edmorley edmorley deleted the docs-broken-links branch May 17, 2018 19:44
@edmorley edmorley added the docs label May 17, 2018
edmorley added a commit that referenced this pull request May 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants