This repository was archived by the owner on Feb 18, 2024. It is now read-only.
Misc monorepo testing improvements #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since no longer used after #877.
Since it simplifies trying it out against `master` locally.
Since `create-project/test/cli_test.js` passes the registry setting itself, so it's not necessary to change the global setting. This saves having to remember to change the setting back if running the `test-create-project-ci.sh` script locally.
|
I ended up dropping the ava upgrade for now, since it broke one of the tests and it's not clear if it's an ava bug or something daft in the |
* Re-uses the `yarn release` command for reduced duplication and to prevent them from getting out of sync. * Uses `--canary` which replaces `--skip-git` and `--cd-version`, and automatically bumps the minor version but also adds a pre-release suffix. eg `8.2.3` -> `8.3.0-alpha.7559e25f`. This will prevent issues when we eventually have verdaccio running on release branches, where the major version bump could clash with that of an actual published newer major version.
eliperelman
approved these changes
May 18, 2018
* Reorders the package definitions, since the first match takes priority (and previously the wildcard was first). * Remove the `proxy` config from the Neutrino packages, meaning that the NPM published packages will never be used, meaning there can never be any clashes / accidentally using an older version, plus no dependency on NPM being online to be able to publish. * Adjust the proxy timeout/max failure counts, so non-Neutrino package downloads are less likely to fail if NPM is being flaky. * Removes unnecessary htaccess auth config since we're using anon. * Removes unnecessary `storage` .gitignore entry since we're using memory storage.
To prevent: * Travis cache churn since the Git SHA changes a lot. * The old packages accidentally being recycled in a later job.
eliperelman
approved these changes
May 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
randompackage.json lifecycle scripttest-create-project-ci.shtest-create-project-ci.shshebang whitespacelerna publishin CIThese are some of the changes split out from #852, plus some others to ensure the verdaccio testing works even when used later on release branches. See individual commit messages for more details.