This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Stop leaking pluginId into the options passed to plugins #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the Neutrino-specific `pluginId` option was being passed along with the plugin-specific options to the plugin constructor in many of the Neutrino presets. Fixes #929.
|
I wonder whether we actually need the ability to pass Thoughts on removing it from a proportion of the presets? (eg stylelint, ...) |
eliperelman
approved these changes
Jun 6, 2018
|
I'm indifferent on the plugin IDs. There are some where it's definitely helpful, but in some cases I'm wondering if it's hurting us or helping us. |
|
I guess we can revisit later :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Neutrino-specific
pluginIdoption was being passed along with the plugin-specific options to the plugin constructor in many of the Neutrino presets.Fixes #929.