Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

karma: Update karma-webpack to 4.0.0-beta.0 #938

Merged
merged 1 commit into from
Jun 7, 2018
Merged

karma: Update karma-webpack to 4.0.0-beta.0 #938

merged 1 commit into from
Jun 7, 2018

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Jun 7, 2018

Since it has improved webpack 4 support and fixes the deprecation warnings. (Sadly it still needs the optimization workaround to prevent hangs after compilation.)

An exact version has been used instead of a caret range in case future beta releases make further breaking changes. Once v4 final is released, we can switch back to caret.

See:
https://github.com/webpack-contrib/karma-webpack/blob/next/CHANGELOG.md#400-beta0-2018-03-19

Since it has improved webpack 4 support and fixes the deprecation
warnings. (Sadly it still needs the `optimization` workaround to
prevent hangs after compilation.)

An exact version has been used instead of a caret range in case
future beta releases make further breaking changes. Once v4 final
is released, we can switch back to caret.

See:
https://github.com/webpack-contrib/karma-webpack/blob/next/CHANGELOG.md#400-beta0-2018-03-19
@edmorley edmorley added this to the v9 milestone Jun 7, 2018
@edmorley edmorley self-assigned this Jun 7, 2018
@edmorley edmorley requested a review from eliperelman June 7, 2018 12:54
Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope there isn't a breaking change in the final release. :)

@eliperelman
Copy link
Member

eliperelman commented Jun 7, 2018

Oh, we should also set this in create-project.

Nevermind, was thinking something else.

@edmorley edmorley merged commit b6937c6 into neutrinojs:master Jun 7, 2018
@edmorley edmorley deleted the karma-4.0.0-beta.0 branch June 7, 2018 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants