This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 233
Config.node
is incorrectly assumed to always be an object
#209
Labels
Comments
Hi! Thank you for filing this issue - I agree webpack-chain should support this case. Would you be open to creating a PR for it? :-) |
Hi! Try to fix this, have a little problem, if i want to add
It will be okay if i fix only |
SuperOleg39
pushed a commit
to SuperOleg39/webpack-chain
that referenced
this issue
Mar 30, 2020
SuperOleg39
pushed a commit
to SuperOleg39/webpack-chain
that referenced
this issue
Mar 30, 2020
SuperOleg39
pushed a commit
to SuperOleg39/webpack-chain
that referenced
this issue
Mar 30, 2020
@edmorley Hello! If you have a time, need PR review) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
webpack-chain makes the incorrect assumption that
Config.node
can never be anything other than an object, despite webpack allowing it to be set tofalse
.As a result, calling
config.set('node', false)
results in the value being lost and thenode
property not existing in the object generated withConfig.toConfig()
.The text was updated successfully, but these errors were encountered: