Give group write perms to socket.

[mrichar1]

I've been looking at the issues with running xrdp as a non-root user, and comparing #16, neutrinolabs/xrdp#464 and the debian packaging patches (https://anonscm.debian.org/cgit/pkg-remote/xrdp.git/tree/debian/patches/fix_perms.diff).

I'm contemplating running xrdp as a non-root user on other distros (e.g. redhat) who don't take the step of patching the package, and was hoping this might be fixable upstream?

I appreciate that the project is reluctant to change the permissions/bits on the whole socketdir directory, but was wondering if just this simple change to the socket itself would be acceptable?

Since the code that creates the socketdir does nothing if the socket already exists, it's easy to make the directory with appropriate permissions before starting the daemon. However there's no way to modify the socket perms without patching, or something a bit more hacky (inotify script, ld_preload library) etc.

I'm fairly sure this change is 'safe' as it should have no effect unless the directory changes have also been made.

Thanks for considering this request!

[metalefty]

Hi, at least I'm welcome with merging such downstream patches if they're worth enough, generic, portable and plausible description provided. I'll check the patch to merge.

Maybe we're not reluctant to change that. Just nobody tells us to change the permission.

[metalefty]

@jsorg71 I'd like to merge this. What do you think?

[jsorg71]

LGTM