Bumped cppcheck version to 2.5

[matt335672]

Small change to bump cppcheck to version 2.5

A small change is also needed to tcutils/utils.h to prevent these warnings:-

utils.cpp:25:5: error: Uninitialized struct member: s.pos [uninitStructMember]
    qstream_new(s, 1024 * 8);
    ^
utils.cpp:25:5: error: Uninitialized struct member: s.size [uninitStructMember]
    qstream_new(s, 1024 * 8);
    ^
utils.cpp:111:5: error: Uninitialized struct member: s.pos [uninitStructMember]
    qstream_new(s, 1024);
    ^
utils.cpp:111:5: error: Uninitialized struct member: s.size [uninitStructMember]
    qstream_new(s, 1024);
    ^

I've managed to verify that the change I've made to tcutils will build on older systems - it doesn't build with our current CI.

The tcutils stuff is based on Qt4 and hence defunct. It's in C++, but doesn't make particularly good use of that language.

Ideally we'd update this utility for Qt5 compatibility, and also improve the C++ usage. I'm personally not that keen on learning all about Qt5 to do this however, given that this utility seems to be more of an example than anything useful.

We seem to have three choices here:-

• Leave this PR as is, and ignore tcutils for now on the grounds it may be useful later.
• Update tcutils to Qt5 (and presumably maintain it)
• Remove the utility entirely.

Thoughts?

[aquesnel]

I'm for removing utilities that don't work and we don't plan to make work.

[matt335672]

Thanks for that - it's a sensible thing to do I think.

Anyone else?

[metalefty]

I agree with @aquesnel. LTGM regarding other part.