Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GFX tidy-ups #2921

Closed
wants to merge 7 commits into from
Closed

GFX tidy-ups #2921

wants to merge 7 commits into from

Commits on Feb 1, 2024

  1. If using GFX, always wait for the channel to come up 

    This change ensures that the window manager login screen state
machine always waits for the GFX virtual channel to come up
before starting, rather than making autologin a special case.

Autlogin isn't commonly used when testing, so this simplifies that
codepath slightly.
    @matt335672
    matt335672 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3467c38 View commit details
    Browse the repository at this point in the history

  2. Fix behaviour if GFX codec could not be chosen 

    Tested the codepath related to a GFX version not being agreed on.
    @matt335672
    matt335672 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ef194df View commit details
    Browse the repository at this point in the history

  3. Improve logging when creating a codec 

    xrdp_encoder_create() is split into two functions to allow for
easier flow control (e.g. checking for a LAN connection type for
the RFX codec)
    @matt335672
    matt335672 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c45d0df View commit details
    Browse the repository at this point in the history

  4. Pass client_info to modules by reference 

    Passing the client_info to the modules by reference (rather than
by value) allows changes made by xrdp_encoder_create() to be
picked up in the client_info message sent by xup to xorgxrdp.
    @matt335672
    matt335672 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    bc459da View commit details
    Browse the repository at this point in the history

  5. Add server_start_encoder() msg to the module interface

    @matt335672
    matt335672 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    bf20e4c View commit details
    Browse the repository at this point in the history

  6. On a resize only restart the encoder if running 

    This change doesn't try to restart the encoder on a resize
if it wasn't running when we started the resize
    @matt335672
    matt335672 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    7ceba6b View commit details
    Browse the repository at this point in the history

  7. Delay starting encoder until needed 

    The encoder is now started if required by the module by using
server_start_encoder(). At present, only XUP does this as the other
modules do not receive screen updates in a suitable form for
calling server_paint_rects() / server_paint_rects_ex()
    @matt335672
    matt335672 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    2ce287d View commit details
    Browse the repository at this point in the history