[V0.10] chansrv clip fixes #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the 256 byte buffer used for names in the XFS filesystem with a dynamically allocated buffer. The define XFS_MAXFILENAMELEN which used to be 255 has been retained, but bumped to 1023. This value is no longer used for long-lived allocations, but is used in chansrv_fuse.c for maintaining state information for in-fligh I/O requests. (cherry picked from commit d8b5435)
The limit of 256 characters for clipboard files is limiting for many Asian locales, particularly as '%xx' notation is used to communicate bytes with bit 7 set. (cherry picked from commit a902282)
This commit ensures that filenames up to the maximum size supported by our xfs can be supported. (cherry picked from commit c3f7eec)
The routine clipboard_get_files() parses a potentially long string, and copies portions of it into a temporary buffer. This buffer is then passed to clipboard_get_file() as pointer + length; The buffer is inadequately sized for very long filenames which may approach XFS_MAXFILENAMELEN in length. This can cause chansrv to fail when the user copies such filenames. It turns out the buffer is unnecessary, as the filenames can be passed directly into clipboard_get_file() from the source string, using pointer + length. This avoids the length limitation entirely. (cherry picked from commit 34b5582)
When used with a FreeRDP client on Linux, a file copy operation from the clipboard detects end-of-file by a read returning 0 bytes. This is currently marked as an error. It is assumed that mstsc.exe detects end-of-file in another way, which is why this has not been found before. (cherry picked from commit 0f6e731)
metalefty
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3165 / #3173 to V0.10
Special thanks to @tsz8899 for raising the original issue and working with the team on resolving it.