Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tconfig: fix setting default value and refine logging #3221

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

metalefty
Copy link
Member

No description provided.

@matt335672
Copy link
Member

I'll look at this ASAP. I'm out of time today after the startwm.sh review.

"[x264.%s] fps_den is not set, adopting the default value [%d]",
rdpbcgr_connection_type_names[connection_type],
X264_DEFAULT_FPS_DEN);
param[connection_type].fps_den = X264_DEFAULT_FPS_DEN;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the point.

@metalefty
Copy link
Member Author

Logging is a cosmetic change. The important change is just one line.

@metalefty
Copy link
Member Author

Code reformat and force-pushed.

Copy link
Member

@matt335672 matt335672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Sorry about the delay.

@metalefty metalefty merged commit 5029bd1 into neutrinolabs:devel Aug 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants