Do not filter out ibc events #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swelf19
reviewed
Sep 12, 2022
x/wasm/keeper/msg_dispatcher.go
Outdated
| @@ -188,12 +188,21 @@ func redactError(err error) error { | |||
| return fmt.Errorf("codespace: %s, code: %d", codespace, code) | |||
| } | |||
|
|
|||
| func isIBCEvent(event sdk.Event) bool { | |||
| for _, attr := range event.Attributes { | |||
| if bytes.Contains(attr.Value, []byte("ibc_")) { | |||
There was a problem hiding this comment.
Are we expecting "ibc_" at any place of string? I mean why not HasPreffix. According to the hermes, he is subscribed only on the module key. May be leave a link to the hermes's line with events description?
swelf19
reviewed
Sep 12, 2022
| @@ -295,9 +294,8 @@ func TestDispatchSubmessages(t *testing.T) { | |||
| }, | |||
| expData: nil, | |||
| expCommits: []bool{true}, | |||
| expEvents: []sdk.Event{sdk.NewEvent("message"), sdk.NewEvent("execute", sdk.NewAttribute("foo", "bar"))}, | |||
| expEvents: []sdk.Event{sdk.NewEvent("execute", sdk.NewAttribute("foo", "bar"))}, | |||
There was a problem hiding this comment.
add a simple test case with an IBC related events?
swelf19
approved these changes
Sep 12, 2022
zavgorodnii
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.