Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes:
Pyre.component is not really used in multiphonon. The associated Histogram.pyrecomponent.Plotter class is not called in multiphonon either.
But Pyre.component is used in mcvine. Pyre.component imports pyre.inventory. Incorporating pyre.inventory into histogram histogram would be complicated due to Pyre.inventory is convoluted with other pyre classes. For testing purpose I temporarily deprecated pyre.components in histogram.
If issue arises during useage of multiphonon this will give us clues on what part of pyre.component is being used.
I've tested that removing pyre.component in histogram doesn't produce failed tests in multiphonon. This PR will allow us to test Histogram without pyre.component.
Instructions to test:
Git clone latest multiphonon-next branch at
git@github.com:neutrons/multiphonon.git
.In the environment.yml file, commenting out last line that pip install histogram from the repository.
conda env create
. This wil create an multiphonon environment without histogram.Git clone
pre_component
branch from histogram repo.cd into histogram folder and
pip install -e .
the histogram that deprecated pyre.component.run pytest in both histogram and multiphonon. All tests should pass.
Multiphonon tests take some time (~1hr) to run. Be patient.
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References