From Powder to Single Crystal Mode Switch #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…model left out itentionally
mpatrou
force-pushed
the
pd_sc_mode_switch
branch
from
6a5bac5 to
09e0654
Compare
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #23 +/- ##
==========================================
+ Coverage 91.40% 92.30% +0.90%
==========================================
Files 10 10
Lines 663 715 +52
==========================================
+ Hits 606 660 +54
+ Misses 57 55 -2 ☔ View full report in Codecov by Sentry. |
|
|
||
| # check the conditions | ||
| if angle_sum > 360 or ( | ||
| alpha_beta_sum < gamma_value or alpha_gamma_sum < beta_value or beta_gamma_sum < alpha_value |
There was a problem hiding this comment.
Make everything <= instead of < I get NaN with 90, 45, 45
KyleQianliMa
pushed a commit
that referenced
this pull request
Jan 14, 2025
* ei value update and passed from view-presenter-model through callback functions * experiment data update -save and restore- on pwoder switch * presenter, tests for mode switch, code cleanup, move for visibility, model left out itentionally * updates after comparing with intermediate model (model still not included) * selection mode init rewrite, presenter cleaunp * qmod boundaries view, model * angle validation added * max modq rename * tests updated for modq with 3 decimal places on the view * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * precommit fixes, double function removed, code cleanup * angles second condition for forming a triangle added * = added in angle validation triangle conditions * tests for validators, sc-pd switch, qmod, etc * switch_to_SC renamed for concistency --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes:
The code includes mainly changes for switching from powder mode to Single crystal. This is the second part of the switch, so any multiple switching back and forth are captured here and the related tests.
Long description of the changes:
It includes the following:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References
Switch from PD and SC mode