Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing internal certificate issue where secret name is null by default #393

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

clemenko
Copy link
Contributor

Fixing internal certificate issue where secret name is null by default. The current chart 2.7.6 defaults cause a null in a volume secret name.

      volumes:
        - name: internal-cert
          secret:
            secretName:

Test with helm template --debug neuvector --namespace cattle-neuvector-system neuvector/core --create-namespace --set internal.certmanager.enabled=true

This PR fixes the defaults. This was working in the chart version 2.7.3.

Commit : 6662ca9
broke it.

@becitsthere becitsthere merged commit 51823ab into neuvector:master Apr 22, 2024
1 check passed
@clemenko
Copy link
Contributor Author

Awesome!
Any chance of a chart update?

@funilrys
Copy link

Hey @becitsthere ,

Is there a way we could get a new chart version with this change ?

Thank you for your time!

Cheers!

@clemenko
Copy link
Contributor Author

While we wait you can add the values back into your yaml or on the command line. https://github.com/clemenko/rke2/blob/main/functions.sh#L283

helm upgrade -i neuvector -n neuvector neuvector/core --create-namespace --set manager.svc.type=ClusterIP --set controller.pvc.enabled=true --set controller.pvc.capacity=500Mi --set internal.certmanager.enabled=true --set manager.ingress.enabled=true --set manager.ingress.host=neuvector.$domain  --set manager.ingress.tls=true --set manager.ingress.secretName=tls-ingress --set cve.adapter.internal.certificate.secret=neuvector-internal --set enforcer.internal.certificate.secret=neuvector-internal --set cve.scanner.internal.certificate.secret=neuvector-internal  --set controller.internal.certificate.secret=neuvector-internal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants